[develop] Release 1.17.1 - Patch transition page to allow single-quote links #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th single-quote characters. Problem - The presence of single-quotes breaks the templating of Javascript - According to RFC3986, single-quotes are reserved in the URI, but double-quotes are considered invalid. Solution - Replace the quotes around the template string to double-quotes - URI encode the presence of all double-quotes in longUrls during HTML templating
liangyuanruo
force-pushed
the
release-1.17.1
branch
from
639ed44 to
562bba1
Compare
yong-jie
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.