Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): relock dependencies to fix security vulnerabilities #1649

Merged
merged 14 commits into from
Jul 29, 2021

Conversation

yong-jie
Copy link
Member

@yong-jie yong-jie commented Jul 28, 2021

Fixes dependency problems highlighted by snyk. Also fixed problems highlighted by npm audit, all this done by removing package-lock and rerunning npm install.

Some dependencies had breaking changes, which caused the typescript compiler to fail. This PR also contains the fixes for them:

  • express-session requires the req.session object to be manually typed. I did this using declaration merging.
  • Update connect-redis to a newer version that is compatible with express-session's breaking change.
  • MUI deprecated a prop in the TablePagination component. I checked the type declaration for information and used the new one
  • MUI also changed the class name of some components, which broke e2e tests which were selecting them. I changed the selectors to use the new MuiCollapse-root element.

@yong-jie yong-jie requested a review from LoneRifle July 29, 2021 03:31
@yong-jie yong-jie marked this pull request as ready for review July 29, 2021 03:31
Copy link
Contributor

@LoneRifle LoneRifle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yong-jie yong-jie merged commit 90b9351 into develop Jul 29, 2021
@yong-jie yong-jie deleted the relock-deps branch July 29, 2021 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants