Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gitpod): use npm install to properly install husky #174

Merged
merged 1 commit into from
Jun 10, 2020

Conversation

LoneRifle
Copy link
Contributor

No description provided.

@LoneRifle LoneRifle requested a review from yong-jie June 10, 2020 09:29
Copy link
Member

@yong-jie yong-jie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related issue is found here. npm ci works only when the version of npm is upgraded. Since we're relying on gitpod's base image, we dont have that much control over this. npm install shouldnt be a big impact on developing on gitpod; approving.

@LoneRifle LoneRifle merged commit db2bbbb into develop Jun 10, 2020
@LoneRifle LoneRifle deleted the gitpod-typo branch June 10, 2020 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants