Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/audit: Periodic security patch for the application #1741

Merged
merged 2 commits into from
Nov 9, 2021
Merged

fix/audit: Periodic security patch for the application #1741

merged 2 commits into from
Nov 9, 2021

Conversation

liangyuanruo
Copy link
Contributor

Periodic security patch for the GoGovSG codebase, via npm audit fix.

The patch did not upgrade major semvers, on closer examination those were related only to devDependencies such as jest and webpack-dev-server.

LoneRifle
LoneRifle approved these changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@LoneRifle LoneRifle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@liangyuanruo liangyuanruo merged commit fb0688d into develop Nov 9, 2021
@liangyuanruo liangyuanruo deleted the fix/audit branch November 9, 2021 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoneRifle LoneRifle LoneRifle approved these changes

@yong-jie yong-jie Awaiting requested review from yong-jie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liangyuanruo @LoneRifle