Chore/trusted by #1846
Merged
Chore/trusted by #1846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yong-jie
reviewed
May 30, 2022
| import trustedBy7 from '@assets/components/home/trusted-by-sliver/7.png' | ||
| import trustedBy8 from '@assets/components/home/trusted-by-sliver/8.png' | ||
|
|
||
| import i18next from 'i18next' |
There was a problem hiding this comment.
could we shift this import so that it is together with the other library imports? thanks!
There was a problem hiding this comment.
Resolved here 13ac1f5
yong-jie
approved these changes
May 30, 2022
Thanks! Let's merge this together with the health assets update. |
gweiying
force-pushed
the
chore/trusted-by
branch
from
7993e5d to
13ac1f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We would like to add a TrustedBy section to our homepage to help establish more trust in our link shortener, by displaying the logos of some of the agencies that use our link shortener.
Solution
Previously, we had a TrustedBy section that was commented out as we did not see a use case for it. This PR performs the following changes:
Importing the alt text from locales will allow us to swap between different trusted organisations across our 3 environments.
Before & After Screenshots
AFTER:
[insert screenshot here]