Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin testcafe version to fix faulty e2e #1849

Merged
merged 1 commit into from
May 30, 2022
Merged

Conversation

gweiying
Copy link
Contributor

@gweiying gweiying commented May 30, 2022

Problem

Our E2E tests are breaking as we have not pinned Testcafe's version, and there seems to be some bugs in handling asynchronicity in Testcafe's new v1.19 release from a couple of days ago.

Details
Tests are failing with the following error thrown by Testcafe's internal libraries:

internal/util.js:279
    throw new ERR_INVALID_ARG_TYPE('original', 'Function', original);
    ^
TypeError [ERR_INVALID_ARG_TYPE]: The "original" argument must be of type function. Received undefined
at promisify (internal/util.js:279:11)
    at Object.<anonymous> (/home/runner/work/GoGovSG/GoGovSG/node_modules/testcafe-safe-storage/lib/file.js:18:33)

More details will be added here after investigating the error more, but this should be a non-blocking investigation. We should pin our Testcafe version regardless as we do not want updates to the library to break our testing.

Solution

Pin Testcafe to v1.18.6

@gweiying gweiying requested a review from yong-jie May 30, 2022 10:55
@gweiying gweiying marked this pull request as ready for review May 30, 2022 10:55
Copy link
Member

@yong-jie yong-jie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for helping with this! this approach lgtm

@gweiying gweiying merged commit 863dc15 into develop May 30, 2022
@gweiying gweiying deleted the fix/testcafe-version branch May 30, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants