Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/health copy #1850

Merged
merged 23 commits into from
Jun 14, 2022
Merged

Chore/health copy #1850

merged 23 commits into from
Jun 14, 2022

Conversation

gweiying
Copy link
Contributor

@gweiying gweiying commented May 31, 2022 •
edited
Loading

Solution

Key changes:

  • Asset, copy and color changes
    • Note: We use dangerouslySetInnerHtml for the new copy changes as some of the new copies include links
  • Add sanitize-html library for sanitising html
  • Add date-fns-tz library for automatically generating copyright year
  • Fix UI states for outline button based on design here
  • Fix console warnings for deprecated arguments and imports on Material UI library

@gweiying gweiying force-pushed the chore/health-copy branch from d8fa4e6 to a42b99d Compare May 31, 2022 10:11
@gweiying gweiying changed the base branch from develop to chore/trusted-by May 31, 2022 10:12
@gweiying gweiying marked this pull request as ready for review June 13, 2022 08:55
@gweiying gweiying marked this pull request as draft June 13, 2022 09:11
@gweiying gweiying marked this pull request as ready for review June 13, 2022 10:25
@gweiying gweiying requested a review from yong-jie June 13, 2022 10:32
Base automatically changed from chore/trusted-by to develop June 13, 2022 10:32
yong-jie
yong-jie approved these changes Jun 13, 2022
View reviewed changes
Copy link
Member

@yong-jie yong-jie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did a broad glance and generally lgtm. using dangerously set HTML seems okay since we have full control over the copy

@gweiying gweiying merged commit 6213466 into develop Jun 14, 2022
@gweiying gweiying deleted the chore/health-copy branch June 14, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yong-jie yong-jie yong-jie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gweiying @yong-jie