chore(husky): enhance with lint-staged #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow husky to invoke lint-staged so that files that are about to be committed get automatically linted. - Update husky, add lint-staged - Add lint-staged commands to lint-fix files before they are committed Closes #183
liangyuanruo
approved these changes
Jun 15, 2020
karrui
reviewed
Jun 15, 2020
| }, | ||
| "lint-staged": { | ||
| "**/*.(js|jsx)": [ | ||
| "eslint --ext .js,.jsx --no-eslintrc -c .eslintrc.json --fix" |
There was a problem hiding this comment.
Don't actually need to pass in .js or .jsx anymore, lint staged automatically does it. Same for the other globs
LoneRifle
added a commit
that referenced
this pull request
Jun 17, 2020
Allow husky to invoke lint-staged so that files that are about to be committed get automatically linted. Closes #183
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Files can currently be committed without linting, which presents inconvenience to the developer at pre-push or CI since the developer has to add or modify a commit to incorporate the linting. lint-staged is designed to avoid precisely this,
git adding any modifications to files (including linting) before commit.Closes #183
Solution
Allow husky to invoke lint-staged so that files that are about to
be committed get automatically linted.
New dev dependencies:
lint-staged: as detailed above