Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(assets): update address bar image for health variant #1886

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

halfwhole
Copy link
Collaborator

Problem

The address bar for the health variant contains an unusually large amount of whitespace because its asset was designed differently from the other asset variants

Closes #1872

Solution

Updated the old image for the health variant with the new version by Christabel

Before & After Screenshots

BEFORE (on desktop):

Screenshot 2022-07-14 at 11 47 12 AM

AFTER (on desktop):

Screenshot 2022-07-14 at 11 47 59 AM

BEFORE (on mobile):

Screenshot 2022-07-14 at 11 48 39 AM

AFTER (on mobile):

Screenshot 2022-07-14 at 11 48 51 AM

Copy link
Contributor

@gweiying gweiying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@gweiying gweiying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@halfwhole halfwhole merged commit 37dcab5 into develop Jul 19, 2022
@halfwhole halfwhole deleted the fix/assets/address-bar-health branch July 19, 2022 02:34
thanhdatle added a commit that referenced this pull request Jul 25, 2022
* feat: updated Docker and CI for Datadog integration

* chore: update readme with for.sg details (#1885)

* fix(assets): update address bar image for health variant (#1886)

* feat: updated Docker and CI for Datadog integration

* feat: updated Docker and CI for Datadog integration

* feat: updated Docker and CI for Datadog integration

* feat: updated Docker and CI for Datadog integration

* feat: updated Docker and CI for Datadog integration

* feat: updated Docker and CI for Datadog integration

* feat: updated Docker and CI for Datadog integration

* feat: updated Docker and CI for Datadog integration

* feat: updated Docker and CI for Datadog integration

* feat: updated Docker and CI for Datadog integration

* feat: updated Docker and CI for Datadog integration

* feat: updated Docker and CI for Datadog integration

* feat: updated Docker and CI for Datadog integration

* feat: updated Docker and CI for Datadog integration

* feat: updated Docker and CI for Datadog integration

* feat: updated Docker and CI for Datadog integration

* feat: updated Docker and CI for Datadog integration

* feat: updated Docker and CI for Datadog integration

* feat: updated Docker and CI for Datadog integration

* feat: updated Docker and CI for Datadog integration

* feat: updated Docker and CI for Datadog integration

* feat: updated Docker and CI for Datadog integration

* feat: updated Docker and CI for Datadog integration

* feat: updated Docker and CI for Datadog integration

* feat: updated Docker and CI for Datadog integration

* feat: updated Docker and CI for Datadog integration

* feat: updated Docker and CI for Datadog integration

* feat: updated Docker and CI for Datadog integration

* feat: updated Docker and CI for Datadog integration

* feat: updated Docker and CI for Datadog integration

* feat: updated Docker and CI for Datadog integration

* feat: updated Docker and CI for Datadog integration

* feat: updated Docker and CI for Datadog integration

* feat: updated Docker and CI for Datadog integration

* feat: updated Docker and CI for Datadog integration

* feat: updated Docker and CI for Datadog integration

* feat: updated Docker and CI for Datadog integration

* feat: updated Docker and CI for Datadog integration

Co-authored-by: halfwhole <41856541+halfwhole@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buggy whitespace display of redirection link
2 participants