-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add datadog back-end logging #1899
Conversation
agreed. for a bit more context, Go's infra was originally of course, we did not need to make any modifications to our RDS instance and therefore the name is still
i vote yes for the same reason you mentioned! |
This what we was guessing ytd
It's a yes from me too! |
nice will go with the new service naming then! the env variable have also updated the tracing utility to enable log injections, which helps datadog to connect our logs with our traces (https://docs.datadoghq.com/tracing/other_telemetry/connect_logs_and_traces/nodejs/) |
791d250
to
862ae7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work, code mostly lgtm. i dropped some suggested changes to improve code safety that we can discuss about!
Problem
Datadog currently does not receive any of our server logs
Solution
Added
datadog-winston
to send our server logs to Datadog. It works on staging, the staging server logs are visible on the log explorerWhat would be a good name for
service
? Having something like[gov/edu/health]-[staging/production]
seems right, but I also have some questions:go
to the beginning (e.g.go-health-production
)? The log explorer contains logs from all projects across OGP, so having a prefix can help to differentiate our project from other teams'go-production
on EB andgosg-production
on RDS. Our team might want to discuss and standardise this?UsingassetVariant
directly might not be the best idea, but this might depend on how we want to define the constants/env variables eventually (pending discussions in feat: datadog integration to client side using datadog/browser-rum lib #1896)Deploy Notes
New dependencies:
datadog-winston
: for sending winston logs to datadogNew dev dependencies:
@types/datadog-winston