feat: add OTP metrics and logging #1904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We'd like to have custom metrics to count the number of OTP successes/failures, and log down both success and failure cases as well
Notion issue here
Solution
Added utility to collect custom Datadog metrics for Go
hot-shotsfor custom metrics collection (as per the Datadog documentation)go.to our custom metrics, to differentiate them from other teams' metricsAdded logging for OTP successes/failures and two custom metrics,
go.otp.successandgo.otp.failureTests
Deploy Notes
New dependencies:
hot-shots: client to collect and send custom metrics to Datadog