build: add env variable for datadog service #1908
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
DD_SERVICE
is not consistently defined for Go across elastic beanstalk, tracing, logs, and monitoring. It's also defined differently fromDD_ENV
even though they serve similar purposes, which may be confusingSolution
Defined
DD_SERVICE
withinci.yml
in a similar manner toDD_ENV
, and standardised its naming togo-[gov/edu/health]
(we should be able to tell whether it's staging or production fromDD_ENV
, so will leave that out of the service naming)Tests
gogovsg
naming though, so that's probably configured somewhere else, or the changes will only take effect once it's been released to production