Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add env variable for datadog service #1908

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

halfwhole
Copy link
Collaborator

@halfwhole halfwhole commented Aug 8, 2022

Problem

DD_SERVICE is not consistently defined for Go across elastic beanstalk, tracing, logs, and monitoring. It's also defined differently from DD_ENV even though they serve similar purposes, which may be confusing

Solution

Defined DD_SERVICE within ci.yml in a similar manner to DD_ENV, and standardised its naming to go-[gov/edu/health] (we should be able to tell whether it's staging or production from DD_ENV, so will leave that out of the service naming)

Tests

  • Tested on staging, the new service naming takes effect for tracing, logs, monitoring - some application metrics (e.g. for RDS and ELB) are still stuck with the gogovsg naming though, so that's probably configured somewhere else, or the changes will only take effect once it's been released to production

@halfwhole halfwhole merged commit 72b3361 into develop Aug 10, 2022
@halfwhole halfwhole deleted the build/add-datadog-service branch August 10, 2022 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants