Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/sns consumer lambda #1913

Merged
merged 3 commits into from
Aug 15, 2022
Merged

Feat/sns consumer lambda #1913

merged 3 commits into from
Aug 15, 2022

Conversation

yong-jie
Copy link
Member

@yong-jie yong-jie commented Aug 10, 2022

Problem

We need a way to capture SES email sending events, which are currently published to an SNS topic.

Solution

Create a lambda that acts as a subscriber to said SNS topic. The actual subscription needs to be done manually, and we can probably just use one single lambda (gov-production maybe?) as the subscriber. In the future, we can split the SES events for gov, edu and health into separate SNS topics and have their respect lambdas subscribe to them.

Deploy Notes

Grab the ARN of the newly created lambda and add it as a subscriber to the SNS topic.

Alternatives considered

We can also introduce an API endpoint in our application, but that introduces unnecessary coupling of the app to this auxiliary feature.

@yong-jie yong-jie marked this pull request as ready for review August 15, 2022 06:48
Copy link
Contributor

@gweiying gweiying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yong-jie yong-jie merged commit 5751d27 into develop Aug 15, 2022
@yong-jie yong-jie deleted the feat/sns-consumer-lambda branch August 15, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants