Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update readme about development one-time passwords #1920

Merged
merged 2 commits into from
Aug 16, 2022

Conversation

jimvae
Copy link
Contributor

@jimvae jimvae commented Aug 16, 2022

Problem

The information about one-time passwords (OTPs) in readme for development is outdated. Maildev is currently being used to obtain OTPs

Solution

Updated readme to include information about obtaining OTPs through maildev for development

@jimvae jimvae added the documentation Improvements or additions to documentation label Aug 16, 2022
@jimvae jimvae requested a review from halfwhole August 16, 2022 15:25
@jimvae jimvae self-assigned this Aug 16, 2022
Copy link
Member

@yong-jie yong-jie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@yong-jie yong-jie merged commit a3f34fb into develop Aug 16, 2022
@yong-jie yong-jie deleted the chore/update-readme-otp-information branch August 16, 2022 16:15
spam or not be sent entirely. To mitigate this, we have set the one-time password for all log-in attempts
on localhost to be `111111`.
but that is really being proxied to `localhost:8080/shortlink`. One-time passwords for all log-in attempts on localhost
are obtained using [maildev](https://github.com/maildev/maildev) and accesed via `http://localhost:1080/`.
Copy link
Collaborator

@halfwhole halfwhole Aug 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh no should be accessed D:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahhhhh crap, lets get another PR open to fix that typo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for this, fixed it in in this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants