Fix/mail

[gweiying]

Problem

I broke our Coveralls tests unknowingly (fell below 75%) when I made the changes to include a Postman fallback option (#1912) without adding tests.

Closes #1915 and #1928

Solution

• Added test routes for email module
• Replaced axios with cross-fetch
• Fixed try-catch nesting for OTP generation and sending

Other notes

I would love to propose that we run Coveralls against PRs to develop. Currently, Coveralls runs on PRs to release, but that since merges to releases are usually after we complete feature development and are prepared to cut a stable version, the coverage tests comes a little belated. Seems like Coveralls runs against develop too, my bad.

Tests

• See Coveralls coverage now
• Jest coverage now

[yong-jie]

lgtm! yes coveralls has always been there for develop branch as well, just that it normally passes and hence gets drowned in the 10-19 other green ticks in the PR checks 😂