refactor: controller service pattern for auth api #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonChong96
force-pushed
the
refactor-login
branch
from
2afb52b to
84d644a
Compare
liangyuanruo
approved these changes
Jun 17, 2020
LoneRifle
pushed a commit
that referenced
this pull request
Jun 17, 2020
* refactor: controller service pattern for login api * refactor: controller service pattern for logout api * fix: logout tests * fix: login test imports * fix: naming for controller tests * fix: test bindings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#156
The backend structure is inconsistent and refactoring is incomplete.
Solution
This PR continues the refactoring process by refactoring auth related endpoints