Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: host name display out of alignment with graphic #1977

Merged
merged 1 commit into from
Oct 5, 2022
Merged

fix: host name display out of alignment with graphic #1977

merged 1 commit into from
Oct 5, 2022

Conversation

darrelhong
Copy link
Contributor

@gweiying gweiying requested a review from halfwhole September 21, 2022 08:11
halfwhole
halfwhole reviewed Sep 22, 2022
View reviewed changes
Copy link
Collaborator

@halfwhole halfwhole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you for contributing! i'll have to double-check with our PM regarding this change though, will get back to you soon!

halfwhole
halfwhole approved these changes Oct 4, 2022
View reviewed changes
Copy link
Collaborator

@halfwhole halfwhole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the delay, checked with PM and looks good!

@halfwhole halfwhole merged commit 27deeb9 into opengovsg:develop Oct 5, 2022
gweiying pushed a commit that referenced this pull request Oct 6, 2022
@darrelhong @gweiying
fix: host name display out of alignment with graphic (#1977)
06dad0b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halfwhole halfwhole halfwhole approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darrelhong @halfwhole