Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document and deprecated code fixes #20

Merged
merged 12 commits into from
Apr 13, 2020
Merged

Document and deprecated code fixes #20

merged 12 commits into from
Apr 13, 2020

Conversation

kylerwsm
Copy link
Contributor

@kylerwsm kylerwsm commented Apr 9, 2020 •
edited
Loading

Problem

  1. Document changes
  • Corrected relevant url domains from datagovsg to opengovsg.
  • Added link to CONTRIBUTION.md from content page of README.md.
  • Changed and standardised GoGovSg capitalisation in CONTRIBUTION.md.
  1. Cleared existing warnings when running npm run lint
  • Fixed eslint warnings regarding PropTypes.
  • Deprecated string refs are replaced with callback refs.
  • Foreign prop type eslint warning is suppressed
  • Upgraded TypeScript eslint packages to get official support for TypeScript version 3.7.2.
  • Added default import for src/server/util/otp.ts to reflect eslint preference for default imports.

@kylerwsm kylerwsm marked this pull request as draft April 9, 2020 11:58
liangyuanruo
liangyuanruo reviewed Apr 9, 2020
View reviewed changes
Copy link
Contributor

@liangyuanruo liangyuanruo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, could you also help draw attention to the Contributing.md file in the Readme?

@kylerwsm kylerwsm changed the title Relevant org domain corrections Document and deprecated code fixes Apr 9, 2020
@kylerwsm kylerwsm marked this pull request as ready for review April 9, 2020 13:55
liangyuanruo
liangyuanruo requested changes Apr 10, 2020
View reviewed changes
Copy link
Contributor

@liangyuanruo liangyuanruo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see unintended code changes, can you rebase?

@kylerwsm
Copy link
Contributor Author

Rebased branch to latest opengovsg:develop.

@kylerwsm kylerwsm requested a review from liangyuanruo April 10, 2020 07:09
@kylerwsm
Copy link
Contributor Author

@liangyuanruo @yong-jie kinda need some help to merge this branch if all is well, I don't have sufficient rights to do it from my end 😅

@yong-jie yong-jie merged commit d935f68 into opengovsg:develop Apr 13, 2020
@kylerwsm kylerwsm deleted the doc-edit branch April 13, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yong-jie yong-jie yong-jie approved these changes

@liangyuanruo liangyuanruo liangyuanruo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kylerwsm @liangyuanruo @yong-jie