chore(e2e): change sub url for e2e tests #2004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halfwhole
force-pushed
the
chore/e2e/change-sub-url
branch
from
1ba5d56 to
74108b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes #2003, see description in issue. TLDR: one local e2e test involving redirecting to
git.luolix.topfailsSolution
Change the
subUrlfromgit.luolix.toptoexample.com. The siteexample.comhas been around for a really long time (see wayback archive), so it seems unlikely to change anytime soon to break the e2e testsStill can't exactly figure out why the issue happened in the first place though, probably some combination of issues on testcafe + github website? :/