feat: bulk backend functionality #2006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: bulk - basic extension, fileSize, virus validation * chore: fix FileCheckController.test.ts * chore: refactor FileCheckController.ts * chore: fix unit tests for FileCheckController.test.ts * feat: csvValidation endpoint * chore: unit tests for CsvCheckController * chore: add BULK_LINK constants * chore: refactor fileExtensionCheck and add circular redirect checks * chore: fix tests, modify parameter name for hasAllowedType, follow size constant convention * refactor: shift bulk upload logic to module/bulk * chore: remove redundant code from BulkController.test.ts * chore: add circular redirect and max link upload unit tests * chore: abstract single file check and improve FilteCheckController and FileTypeFilterService tests
…opengovsg/GoGovSG into feat/bulk-backend
Co-authored-by: halfwhole <41856541+halfwhole@users.noreply.github.com>
…opengovsg/GoGovSG into feat/bulk-backend
gweiying
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What problem are you trying to solve? What issue does this close?
Closes [insert issue #]
Solution
How did you solve the problem?
Features:
Improvements:
Bug Fixes:
Before & After Screenshots
BEFORE:
[insert screenshot here]
AFTER:
[insert screenshot here]
Tests
What tests should be run to confirm functionality?
Deploy Notes
Notes regarding deployment of the contained body of work. These should note any
new dependencies, new scripts, etc.
New environment variables:
env var: env var detailsNew scripts:
script: script detailsNew dependencies:
dependency: dependency detailsNew dev dependencies:
dependency: dependency details