Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tagging): include underscores in error message for invalid tags #2010

Merged
merged 2 commits into from
Oct 10, 2022

Conversation

halfwhole
Copy link
Collaborator

Problem

The error message for invalid tags on the create new link modal currently does not include underscores in its description.

Solution

Add underscores to the error message for invalid tags.

Before & After Screenshots

BEFORE:
Screenshot 2022-10-06 at 7 32 45 PM

AFTER:
Screenshot 2022-10-06 at 7 29 57 PM

@halfwhole halfwhole force-pushed the fix/tagging/underscores-message-invalid-tags branch from fd9df50 to 4cd4d28 Compare October 7, 2022 02:53
Copy link
Contributor

@gweiying gweiying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@halfwhole halfwhole merged commit a5feb71 into develop Oct 10, 2022
@halfwhole halfwhole deleted the fix/tagging/underscores-message-invalid-tags branch October 10, 2022 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants