Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(lambda): update sql scripts for transferring links with tagStrings #2014

Merged
merged 1 commit into from
Oct 10, 2022
Merged

chore(lambda): update sql scripts for transferring links with tagStrings #2014

merged 1 commit into from
Oct 10, 2022

Conversation

halfwhole
Copy link
Collaborator

@halfwhole halfwhole commented Oct 7, 2022 •
edited
Loading

Problem

When using lambda functions to transfer links, the url history records created should contain the tagStrings as well

Solution

Add tagStrings as a column to be inserted into url_histories in the SQL scripts

Tests

  • Test both lambda functions for transferring links on staging

Deploy Notes

  • Post deploy: the SQL functions need to be updated

gweiying
gweiying approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@gweiying gweiying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@halfwhole halfwhole marked this pull request as ready for review October 10, 2022 06:02
@halfwhole halfwhole merged commit b0818c7 into develop Oct 10, 2022
@halfwhole halfwhole deleted the chore/lambda/update-sql-scripts-tag-strings branch October 10, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gweiying gweiying gweiying approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@halfwhole @gweiying