Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tagging): allow tags to be added on space, comma, clickaway #2025

Merged
merged 3 commits into from
Oct 13, 2022

Conversation

halfwhole
Copy link
Collaborator

@halfwhole halfwhole commented Oct 12, 2022

Problem

Currently, adding tags requires the user to press enter, which can be non-obvious and unintuitive.

Solution

Allow tags to be added when the user presses enter, space, comma, or clicks away from the tags input.

But a slight ordering problem happens when the user clicks away from the tags input to the "create link" or "save" button at one go:
- When the user clicks "create link" on the create link form, first the tag input is added, then the link is created;
- When the user clicks "save" on the edit link form, first the link is saved, then the tag input is added.

edit: above problem is fixed, always adds tags before saving. but the solution might be a little unclean though

Some extra fixes: slight amendments to logic for disabling save/create link buttons

@halfwhole halfwhole force-pushed the fix/tagging/add-new-tag-keys branch from 2c1b641 to 4c8ed85 Compare October 13, 2022 01:24
Copy link
Contributor

@thanhdatle thanhdatle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@halfwhole halfwhole merged commit b763936 into develop Oct 13, 2022
@halfwhole halfwhole deleted the fix/tagging/add-new-tag-keys branch October 13, 2022 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants