fix(tagging): align error text with save button on edit link drawer #2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See issue description in #2026
Closes #2026
Solution
On the edit link form, ensure that the tags field is aligned with the save button, by fixing the helper text's position so that it does not take extra height.
However, we need a way to toggle between making the helper text add extra height on the create link form, and adding no height on the edit link form. This is done through the use of the boolean variable
fixHelperTextPosition.Screenshots
Before:
Create link form
Screen.Recording.2022-10-13.at.4.19.47.PM.mov
Edit link form
Screen.Recording.2022-10-13.at.4.20.57.PM.mov
After:
Create link form: unchanged from before
Edit link form
Screen.Recording.2022-10-13.at.4.24.02.PM.mov