refactor: extract QrCodeService #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liangyuanruo
requested changes
Jun 21, 2020
kylerwsm
force-pushed
the
refactor-services
branch
from
fb8a63e to
9ede75b
Compare
|
Addressed merge conflicts |
liangyuanruo
approved these changes
Jun 22, 2020
kylerwsm
force-pushed
the
refactor-services
branch
from
436d9cc to
b92b267
Compare
|
Suggestions accepted and passed CI |
|
Is this related to #156 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR contribute towards refactoring our backend to adopt the controller service repository pattern. Specifically, in this PR, I extracted QrCodeService from our /qrcode endpoint.