chore(datadog): add metrics for malicious file or link activity #2031
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the metrics for malicious activity are defined under metric filters for CloudWatch log groups. (See AWS console for more details, requires AWS permissions to access)
The current approach presents several problems:
Solution
Add two new malicious activity metrics that will be sent to Datadog: one for malicious files (
go.malicious_activity.file
), and one for malicious links (go.malicious_activity.link
). The env and service tags for staging/prod and gov/edu/health respectively should be added on Datadog automatically. This will allow us to remove metric filters on CloudWatch in the future as well, if we want to.Improvements:
Resolved a TODO comment from before (#1993 (comment)) in
UrlManagementService.ts
. For the shortlink creation metric, a new tag was also added to label the source (console or bulk, but not yet API).Tests
Deploy notes
Post-deployment: can remove CloudWatch metric filters for malicious activity (optional, but would be nice to do)