-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/apikey dashboard #2035
Merged
Merged
Feat/apikey dashboard #2035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
thanhdatle
force-pushed
the
feat/apikey-dashboard
branch
from
November 2, 2022 06:29
0589b1b
to
ff0e0b7
Compare
thanhdatle
force-pushed
the
feat/apikey-dashboard
branch
from
November 3, 2022 07:33
222df8a
to
0165d8e
Compare
halfwhole
approved these changes
Nov 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Have put down a whole bunch of comments, but they're really nits that mostly have to do with minor frontend styling - works good without them!
src/server/modules/user/interfaces/ApiKeyAuthServiceInterface.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: halfwhole <41856541+halfwhole@users.noreply.github.com>
Co-authored-by: halfwhole <41856541+halfwhole@users.noreply.github.com>
Co-authored-by: halfwhole <41856541+halfwhole@users.noreply.github.com>
halfwhole
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Implement API Dashboard for user to generate APIKey, which is used to authenticate external APIs.
Solution
A new API endpoint is introduced:
api/user/hasApiKey
which returns either:
{"message":"true"}
or{"message":"false"}
to indicate if user already has an API Key
If user has not generated API Key:
If user has generated API Key:
ApiKey modal is only shown once for user to copy API Key
The navigation header is also updated to add Dashboard and API Integration page