Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tagging): allow backspaces to remove tags #2039

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

halfwhole
Copy link
Collaborator

@halfwhole halfwhole commented Oct 18, 2022

Problem

Currently, clicking on the 'x' on a tag on the create/edit link forms is the only way to remove the tag. Backspace doesn't do this, which may be unintuitive or non-keyboard friendly.

See Notion issue

Solution

Allow backspaces to remove tags.

Copy link
Contributor

@gweiying gweiying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@halfwhole halfwhole merged commit 4808420 into develop Oct 18, 2022
@halfwhole halfwhole deleted the feat/tagging/backspace-remove-tag branch October 18, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants