fix: restrict state to active and inactive in directory search #2051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Similar to #2050, the query conditions for
statewhen searching for URLs in the directory page are overly permissive, and should be restricted to either active or inactive states.See Snyk dashboard - Improper Type Validation
Solution
Use Joi validator to allow the optional
statefield to be only one ofACTIVE,INACTIVE. (updated to remove''following comments in the other PR!) (Joi validated fields are optional by default)No controller tests can be added here - the Joi validation happens in the middleware before hitting the controller level