fix: add second order by shortUrl when searching for links #2053
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Bulk-created links with the same
createdAt
time are not necessarily returned in the same order when sorting links bycreatedAt
only. This may cause issues, like the sort order of bulk links suddenly changing when one of the links is updatedSee Notion issue - [Create] Link sort order seems to be changed after adding the tag and Notion issue - [Create] [Update] Link status changes after adding or updating the tag
Solution
Add a second
ORDER BY
condition onshortUrl
, leading to a deterministic ordering with bulk-created linksshortUrl
doesn't seem to be an indexed field (but then again, we're currently ordering bycreatedAt
which doesn't seem to be indexed either)