Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): bump bcrypt from 5.0.1 to 5.1.0 #2056

Merged
merged 1 commit into from
Nov 2, 2022
Merged

build(deps): bump bcrypt from 5.0.1 to 5.1.0 #2056

merged 1 commit into from
Nov 2, 2022

Conversation

halfwhole
Copy link
Collaborator

Problem

bcrypt 5.0.1 is out-of-date: it depends on an old version of an ansi-regex that contains a ReDoS vulnerability (see Snyk dashboard)

bcrypt is currently used for hashing and cryptography for OTPs

Solution

Update bcrypt to 5.1.0

Tests

  • Test on local and staging to ensure that OTP logins still work

@halfwhole halfwhole merged commit 00bb3a1 into develop Nov 2, 2022
@halfwhole halfwhole deleted the build/deps/update-bcrypt branch November 2, 2022 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thanhdatle thanhdatle thanhdatle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@halfwhole @thanhdatle