feat: add announcement modal for gov #2059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Unlike health and edu asset variants, the gov asset variant does not have an announcement modal image
Solution
Add an announcement modal image for the gov asset variant.
Note that to use this image in the announcement modal, the env variable
ANNOUCEMENT_IMAGEhas to be set to/assets/gov/transition-page/images/announcement-modal.svgBefore & After Screenshots
AFTER:
Example of how the new announcement modal might look:
Deploy Notes
Post-deploy: update
ANNOUNCEMENT_IMAGEto/assets/gov/transition-page/images/announcement-modal.svgon gov staging and production