feat: allow html for announcement modal message #2063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The announcement modal currently does not allow HTML inside its message, preventing us from using clickable hyperlinks.
Solution
Allow HTML for the announcement modal message. Since we control the announcement message (through the
ANNOUNCEMENT_MESSAGEenv variable), this should be safe.display: flextodisplay: blockto avoid new HTML elements from being added in new columnshmtlSanitizertohtmlSanitizerBefore & After Screenshots
AFTER:
ANNOUNCEMENT_MESSAGEhere is set toYou can now tag your links and manage your dashboards effectively. Learn more about this on <a href="https://guide.go.gov.sg/guide-1/link-tagging">our guide</a>.\nFurthermore, our team is constantly looking for new problems to solve for our users. If you would like us to build a solution for you, please provide your thoughts <a href="https://go.gov.sg/go-pain-point-survey">here</a>!