Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tagging): fix filtering for no results when searching by tags #2068

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

halfwhole
Copy link
Collaborator

Problem

To reproduce:

  • Login and go to the user page, ensure that you have some links
  • Search for a non-existent tag
  • Search bar disappears and page says that you have no short links

Regression likely introduced by #2037, by separating searchText out into searchText and tags

Closes Notion issue

Solution

Change the condition for determining if the user has searched/filtered for URLs, by also checking for the existence of tags in tableConfig

Before & After Screenshots

BEFORE:
When searching for a non-existent tag:
Screenshot 2022-11-03 at 2 54 39 PM

AFTER:
When searching for a non-existent tag:
Screenshot 2022-11-03 at 2 55 31 PM

Tests

  • Add E2E test for searching for non-existent tag
  • Add E2E test for searching for non-existent link

Also shortened the wait time for searching for tags from 3s -> 2s, which still seems more than long enough. Wait time for searching for links remains at 1s

Copy link
Contributor

@thanhdatle thanhdatle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@halfwhole halfwhole merged commit a0ad977 into develop Nov 7, 2022
@halfwhole halfwhole deleted the fix/search-tags-no-results branch November 7, 2022 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants