fix(tagging): fix filtering for no results when searching by tags #2068
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
To reproduce:
Regression likely introduced by #2037, by separating
searchText
out intosearchText
andtags
Closes Notion issue
Solution
Change the condition for determining if the user has searched/filtered for URLs, by also checking for the existence of
tags
intableConfig
Before & After Screenshots
BEFORE:
When searching for a non-existent tag:
AFTER:
When searching for a non-existent tag:
Tests
Also shortened the wait time for searching for tags from 3s -> 2s, which still seems more than long enough. Wait time for searching for links remains at 1s