-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: data collection for search #207
Conversation
8cd43b6
to
0cd76e2
Compare
src/server/models/url.ts
Outdated
allowNull: false, | ||
validate: { | ||
isEmail: true, | ||
isLowercase: true, | ||
is: emailValidator.makeRe(), | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't there an inconsistency, if the default value populated by the SQL migration is an empty string, but here we are insisting on allowNull: false
and isEmail: true
?
would it be easier to simply allow null values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's dangerous to backfill empty strings in the DB, yet insist on non-nullable email validation in the ORM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Problem
Before link search can be fully implemented, further collection of data from link owners is required.
#181
Solution
This PR implements phase 0 of the implementation for link search. UI Fields and database columns are added for contact information and description for each link.
Improvements:
DrawerTextField
have been replaced by having helper text in absolute position. The negative margins made it hard to debug element positioning in browser debuggers and calculations of margins needed for subsequent elements were also confusing.Before & After Screenshots
AFTER:
Desktop
Mobile
Deploy Notes
The new migration script should be run before deployment. The new columns will be nullable and compatible with both the new and old code.
TODO: