feat(api): add feature flag for external API #2077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
|
^ ignore the above gitguardian comment, it relates to |
thanhdatle
approved these changes
Nov 16, 2022
halfwhole
force-pushed
the
feat/api/feature-flag
branch
from
e0bc191 to
a0868d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We want to have a feature flag to toggle between enabling/disabling the external API
Solution
Introduce a new optional env variable
FF_EXTERNAL_API, a boolean that defaults to false unless explicitly set totrue. This variable controls whether the external API v1 routes are enabled.Deploy Notes
New environment variables:
FF_EXTERNAL_API(optional): feature flag for external API that defaults to falsePre-deploy or post-deploy: set
FF_EXTERNAL_APItotrueto enable it when we're ready