chore: change default session cookie max age to 1 day #2086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gweiying
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It's really tiring for devs to have to log in again every 30 mins
Solution
Change the default
COOKIE_MAX_AGEfrom 1800000 (30 mins) to 86400000 (1 day) indocker-compose.yml.COOKIE_MAX_AGEis already set to 86400000 on gov/edu/health prod, so there will be no change at all to productionCOOKIE_MAX_AGEwas set at 30 mins 3 years ago, but since prod already overrides this to 1 day anyway, I figure that bumping everything to 1 day by default is fine