Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): amend header spacing on api integration page #2088

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

halfwhole
Copy link
Collaborator

Problem

The header spacing on the API integration page is a little bit wonky, see Notion issue

Solution

Features:

  • Adjusted the header spacing so it looks a little better

Improvements:

  • Removed the align-self property, which does not affect the layout (devtools also says that left is not a valid value)

Before & After Screenshots

BEFORE:

Desktop:
Screenshot 2022-11-22 at 11 47 59 AM

Mobile:
Screenshot 2022-11-22 at 11 47 12 AM

AFTER:

Desktop:
Screenshot 2022-11-22 at 11 46 40 AM

Mobile view remains entirely unchanged

@halfwhole halfwhole requested a review from thanhdatle November 22, 2022 03:51
Copy link
Contributor

@thanhdatle thanhdatle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thanhdatle thanhdatle merged commit ee8df77 into develop Nov 22, 2022
@thanhdatle thanhdatle deleted the feat/api/amend-header-spacing branch November 22, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants