Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set apiEnv according to DD_ENV instead of NODE_ENV #2090

Merged
merged 1 commit into from
Nov 22, 2022
Merged

fix: set apiEnv according to DD_ENV instead of NODE_ENV #2090

merged 1 commit into from
Nov 22, 2022

Conversation

thanhdatle
Copy link
Contributor

Problem

NODE_ENV is set to production in both Staging and Production environment, causing apiEnv to have live_ prefix in both staging and prd

Solution

To make apiEnv to rely DD_ENV instead.

@thanhdatle thanhdatle requested a review from halfwhole November 22, 2022 06:59
halfwhole
halfwhole approved these changes Nov 22, 2022
View reviewed changes
Copy link
Collaborator

@halfwhole halfwhole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - feels a little hackish to be relying on DD_ENV, but should be the simplest option for now

@thanhdatle thanhdatle merged commit 0ffd097 into develop Nov 22, 2022
@thanhdatle thanhdatle deleted the fix/api-env-rely-on-dd-env branch November 22, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halfwhole halfwhole halfwhole approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thanhdatle @halfwhole