feat: improve validations and errors for shortUrl and longUrl #2100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The server errors for invalid short and long URLs are not always caught up-front at the Joi validator level, leaving them to be caught at the Sequelize level or via safe browsing checks (which is not that great). Plus, the error messages thrown are not very informative or well-formatted.
Closes this Notion issue
Solution
urlCheckController
) and various file checks (infileCheckController
)There's a bit of error duplication across the Joi schemas and Seqeulize validations, but I can't think of an easy fix - it seems ok for now, so will leave it as it is
Tests