fix: update safe browsing error messages #2101
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Safe browsing errors are not being logged and returned properly.
The returned error message looks like this, because
response
andresponse.body
are objects:The logged error message looks like this, because it's trying to log
error
instead oferror.message
:Solution
response
andresponse.body
tobody.error.message
error
toerror.message
Now, both the logged and returned error messages look like this:
For context, when calling the Safe Browsing API, the reponse JSON
body
looks something like this when there's an error:The indentation changes from line 83/84 onwards in this PR are caused by prettier
Also, apologies to the team for unintentionally exposing the now-removed API key 🙇