Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix localstack version in docker-compose to 1.2 #2112

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

halfwhole
Copy link
Collaborator

@halfwhole halfwhole commented Dec 5, 2022

Problem

docker-compose.yml is using localstack:latest, which has recently bumped its latest version from v1.2.0 to v1.3.0. Apparently the local AWS bucket somehow does not work the same way in localstack v1.3.0, and hence file uploads and E2E tests are failing.

Solution

Fix the version of localstack to 1.2 in docker-compose.yml.

(If we want to upgrade to localstack v1.3.0 eventually, we'll have to figure out how to make local S3 work with it.)

Other notes:

  • Integration tests are helpful for debugging!
  • Try pinning down specific versions of images instead of using latest, because it makes the project vulnerable to package upgrades which may suddenly and inexplicably break things
  • Curiously I still can't replicate this problem locally, despite killing all docker containers and restarting them - does anyone have any ideas why?

@halfwhole halfwhole merged commit d7a7d16 into develop Dec 5, 2022
@halfwhole halfwhole deleted the build/use-localstack-1.2 branch December 5, 2022 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants