Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(localstack): corrected whitelist, test, and compose file #212

Merged
merged 1 commit into from
Jun 22, 2020

Conversation

kylerwsm
Copy link
Contributor

@kylerwsm kylerwsm commented Jun 22, 2020

Problem

In earlier PRs, we have simplified the localstack endpoint. However, the whitelist is not updated. This prevents the upload of files in development, as localstack urls are not considered valid urls. In addition, our tests and docker-compose file can also be updated or simplified.

Solution

  • Corrected the whitelist url to http://localhost:4566.
  • Update tests for whitelist validation to use http://localhost:4566.
  • Expose only port 4566 for localstack in our compose file.

@liangyuanruo liangyuanruo merged commit 85c9fd6 into develop Jun 22, 2020
@liangyuanruo liangyuanruo deleted the whitelist-fix branch June 22, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants