Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add dd metrics for link and file scan failures #2145

Merged
merged 2 commits into from
Jan 12, 2023

Conversation

gweiying
Copy link
Contributor

Add metric namespaces to track file and link scan failures

@halfwhole halfwhole self-requested a review January 12, 2023 07:56
Copy link
Collaborator

@halfwhole halfwhole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for doing this!

Comment on lines 9 to 10
export const SCAN_FAILED_FILE = 'scan.file.failure'
export const SCAN_FAILED_LINK = 'scan.link.failure'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe can list in alphabetical order? but this grouping makes sense so it's okay too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed 0266848

@gweiying gweiying merged commit 34de12c into develop Jan 12, 2023
@gweiying gweiying deleted the fix/backend/scan-failure-dd branch January 12, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants