build(deps-dev): update webpack-related dependencies #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove url-loader (not used) and style-loader (no client CSS, styling now done via React themes) - Update README to reflect this
Remove explicit argument to clean output directory, as v2+ defaults to output.path
LoneRifle
force-pushed
the
chore/deps/webpack
branch
from
e035aaa to
b0458d8
Compare
liangyuanruo
approved these changes
Jun 23, 2020
|
i wonder how hard is it to retrospectively introduce |
|
Why would you? Your app is already created |
|
Chunking, tree shaking and minification etc |
|
Wouldn't it make more sense to introduce those features into webpack instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem and Solution
As part of ongoing efforts to bring dependencies up-to-date, update webpack-related packages and eliminate the ones we no longer use
styling now done via React themes)
to output.path
Tested through
npm run dev