Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] increase e2e test confidence #2165

Merged
merged 18 commits into from
Mar 15, 2023
Merged

[Test] increase e2e test confidence #2165

merged 18 commits into from
Mar 15, 2023

Conversation

oversparkling
Copy link
Contributor

@oversparkling oversparkling commented Mar 6, 2023

Problem

Closes #2124

Features:

  • Increases code confidence of our repository, especially our virus scanner on files

Noticable changes from this PR

  • Local E2E tests may fail locally if there is a urls.csv lurking in downloads folder
  • Changes made to docker-compose will require a .env file to be present in local directory (KIV on this approach atm)

Tests

What tests should be run to confirm functionality?
Contribution to E2E Tests

@oversparkling oversparkling changed the title Test/e2e test [Test] increase e2e test confidence Mar 6, 2023
@oversparkling oversparkling marked this pull request as ready for review March 10, 2023 09:01
package.json Outdated Show resolved Hide resolved
@gweiying
Copy link
Contributor

Noting that above tests addresses these test cases:

User page

  • Ellipses are shown for very long links

URL creation

URL Searching and Download (?)

  • Clicking on the download button downloads all links currently shown in the links table as a .csv file.

User page - Sort & Filter

  • Links should be sorted by their number of clicks in descending order when enabling sort by Most number of visits and clicking apply

@oversparkling
Copy link
Contributor Author

oversparkling commented Mar 15, 2023

Referencing this, we removed empty variables from being assigned in docker-compose so that it defaults to .env file that is created during CI.

Copy link
Contributor

@gweiying gweiying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@oversparkling oversparkling merged commit 8fc02ec into develop Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E tests
2 participants