fix: identify google page renderer user agent as a bot #2167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
tldr; our server is wrongly classifying google's page renderer bot as a user on "Desktop", when it should be classified under "Others" instead. full story:
Solution
Change the
BOTS_USER_AGENTS
expression to includeGoogle-PageRenderer
.Doing this might not work for the long-term though. The current solution to check for bots was implemented in #209, a custom-written
BOTS_USER_AGENTS
expression is used to determine if a user-agent is a bot or not. But naturally, the expression cannot exhaustively cover all possible bots, leading to many other bots falling through the cracks (like this google page renderer bot).In the future, we may want to opt for a more comprehensive solution from using a library like isbot