Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/file size increase #2169

Merged
merged 6 commits into from
Mar 13, 2023
Merged

Chore/file size increase #2169

merged 6 commits into from
Mar 13, 2023

Conversation

gweiying
Copy link
Contributor

@gweiying gweiying commented Mar 9, 2023

Problem

We want to support file uploads of size 15-20MB.

Solution

This PR increases the supported file upload size to 20MB. Note that uploading large files takes longer as the file is sent to Cloudmersive for virus scanning. On average, 20MB files take 25s for uploading, but can also take up to 55s for uploading. If the response time goes beyond 1 min, the upload fails and the user is prompted to try again.

Others

  • Fixed bug where bulk upload and file upload input was using the same file size limit
  • Added util file to parse byte sizes Unneeded

@gweiying gweiying requested a review from halfwhole March 9, 2023 05:42
Copy link
Collaborator

@halfwhole halfwhole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gweiying gweiying requested a review from halfwhole March 10, 2023 05:52
Copy link
Collaborator

@halfwhole halfwhole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@gweiying gweiying merged commit 3adafc3 into develop Mar 13, 2023
@gweiying gweiying deleted the chore/file-size-increase branch March 13, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants