Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(link-transfer): add request ownership button to directory table #2179

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

halfwhole
Copy link
Collaborator

@halfwhole halfwhole commented Mar 14, 2023

Problem

Part of the link transfer feature (see Notion doc)

Solution

This PR adds a "Request ownership" button to the directory table. On mobile, the button will not be shown on the table but only appears in the bottom panel (after the user clicks on the table row).

Clicking on "Request ownership" will take the user to Go's Contact Us form. In the future, clicking it should instead create an actual link transfer request and send an email out to the link owner, but as a first step we've agreed with product-side to redirect them to the contact form first.

Notes:

Ideally, the "Request ownership" button should be an actual Button component instead of a Link, but the CSS on the directory table is such a mess that it's a bit difficult to figure out a proper styling -- it should still be alright to have it as a link though, as that would be consistent with the other clickable links on the table too (e.g. contact email).

On the mobile panel though, the "Request ownership" button is actually a Button.

Improvements:

  • Removed some unused CSS
  • Removed some unnecessary padding/whitespace (to also make room for the "Request ownership" link)

Before & After Screenshots

BEFORE:
Screenshot 2023-03-14 at 5 52 28 PM
Screenshot 2023-03-14 at 5 52 58 PM

AFTER:
Screenshot 2023-03-14 at 5 53 22 PM
Screenshot 2023-03-14 at 5 53 46 PM

Screen.Recording.2023-03-14.at.5.54.59.PM.mov

@halfwhole halfwhole requested a review from gweiying March 15, 2023 02:59
Copy link
Contributor

@gweiying gweiying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@halfwhole halfwhole merged commit 1a4f22f into develop Mar 15, 2023
@halfwhole halfwhole deleted the feat/link-transfer/request-ownership-button branch March 15, 2023 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants