Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): pick up drop-in changes to server, @types #219

Merged
merged 2 commits into from
Jun 29, 2020

Conversation

LoneRifle
Copy link
Contributor

@LoneRifle LoneRifle commented Jun 25, 2020

Problem

GoGovSG's dependencies are currently in need of updating. Once done, dependabot can be used to keep them updated.

Solution

Update the following deps, test by exercising corresponding function:

  • @hapi/joi, bcrypt - login via OTP

  • sharp - QR code generation

  • aws-sdk - file uploads

  • winston - logging

  • nodemailer - to be tested on staging

  • update the types for: bluebird, lodash, sinon, validator, jest

@liangyuanruo
Copy link
Contributor

lgtm, to merge after testing nodemailer

@LoneRifle LoneRifle force-pushed the chore/deps/types branch 3 times, most recently from c80a763 to f190ec7 Compare June 26, 2020 11:18
Update the following deps, test by exercising corresponding function:

- `@hapi/joi`, `bcrypt` - login via OTP
- `sharp` - QR code generation
- `aws-sdk` - file uploads
- `winston` - logging

- `nodemailer` - to be tested on staging
@LoneRifle
Copy link
Contributor Author

LoneRifle commented Jun 29, 2020

Tested in staging; nodemailer successfully sent OTP

@LoneRifle LoneRifle merged commit 084673f into develop Jun 29, 2020
@LoneRifle LoneRifle deleted the chore/deps/types branch June 29, 2020 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants